Drop TravisCI testing in favor of GitHub Actions, test up to PHP 8.0 #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enumag
reviewed
Oct 2, 2021
Comment on lines
+20
to
+21
| // Avoid throwing a risky test error. | ||
| $this->assertTrue(true); |
There was a problem hiding this comment.
You can use expectNotToPerformAssertions() instead.
Although... not sure if it exists in old PHPUnit versions.
There was a problem hiding this comment.
Not sure in PHPUnit 4? Tests need to run on PHP 5.4 too.
Merged
|
ping @PhenX who seems the only person able to commit here |
enumag
reviewed
Oct 2, 2021
|
not really necessary for the next milestone, but I assigned there to remind me to take a look |
bsweeney
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TravisCI has become overly complicated to test on for OSS, most projects I follow shifted to GitHub Actions instead.
This PR removes TravisCI configuration, sets up GithHub actions for running on a weekly schedule for testing on all PHP versions from 5.4 to 8.0.
PHP 8.1 should be managed as a separate PR because it will require more changes (for example, #93).